Skip to content

Allow platforms without fixed version in profiles. #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2025
Merged

Allow platforms without fixed version in profiles. #2940

merged 4 commits into from
Jul 4, 2025
+121 −15

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 30, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

The idea is to allow in the sketch.yml platforms without a specific version, like the following giga_any:

profiles:
  giga:
    fqbn: arduino:mbed_giga:giga
    platforms:
      - platform: arduino:mbed_giga (4.3.1)

  giga_any:
    fqbn: arduino:mbed_giga:giga
    platforms:
      - platform: arduino:mbed_giga      # this does not specify a version
      # no need to specify index_url either

default_profile: giga_any

In this case, the Arduino CLI will not download the platform to the internal space, but it will use the globally installed platform.

What is the current behavior?

You must specify a version in the platform directive of the sketch.yml

What is the new behavior?

You can omit a version in the platform directive of the sketch.yml, in this case the Arduino CLI will use the globally installed platform.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie self-assigned this Jun 30, 2025
@cmaglie cmaglie added type: enhancement Proposed improvement topic: CLI Related to the command line interface topic: build-process Related to the sketch build process labels Jun 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.96552% with 18 lines in your changes missing coverage. Please review.

Project coverage is 68.03%. Comparing base (3dca438) to head (863f46e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/arduino/sketch/profiles.go 80.00% 5 Missing and 5 partials ⚠️
commands/instances.go 0.00% 4 Missing and 1 partial ⚠️
internal/arduino/cores/packagemanager/profiles.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2940      +/-   ##
==========================================
+ Coverage   67.96%   68.03%   +0.06%     
==========================================
  Files         238      238              
  Lines       22524    22567      +43     
==========================================
+ Hits        15309    15353      +44     
  Misses       6013     6013              
+ Partials     1202     1201       -1
Flag Coverage Δ
unit 68.03% <68.96%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie cmaglie force-pushed the profile_with_global branch from 5134139 to a49dd21 Compare July 3, 2025 11:23
@cmaglie cmaglie linked an issue Jul 3, 2025 that may be closed by this pull request
Support for custom libraries when using sketch.yaml #2133
Open
6 tasks
@cmaglie cmaglie removed a link to an issue Jul 3, 2025
Support for custom libraries when using sketch.yaml #2133
Open
6 tasks
@cmaglie cmaglie linked an issue Jul 3, 2025 that may be closed by this pull request
Support manually installed platforms in build profiles #2927
Closed
3 tasks
@cmaglie cmaglie force-pushed the profile_with_global branch from a49dd21 to 863f46e Compare July 3, 2025 16:43
@cmaglie cmaglie marked this pull request as ready for review July 3, 2025 18:02
@cmaglie cmaglie requested a review from a team July 4, 2025 09:19
@cmaglie cmaglie merged commit 3db4ad8 into arduino:master Jul 4, 2025
172 of 175 checks passed
@cmaglie cmaglie deleted the profile_with_global branch July 4, 2025 10:44
@cmaglie cmaglie mentioned this pull request Jul 4, 2025
Closed
3 tasks
@per1234 per1234 added topic: code Related to content of the project itself and removed topic: CLI Related to the command line interface labels Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: build-process Related to the sketch build process topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support manually installed platforms in build profiles
3 participants
@cmaglie @alessio-perugini @per1234